Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce the fixes for bag/mix symdif #187

Merged
merged 2 commits into from Jan 1, 2017

Conversation

ab5tract
Copy link
Contributor

@ab5tract ab5tract commented Dec 4, 2016

This time, we don't change any of the set tests.

All of the 'showkv' calls were removed as they are no longer necessary
and several new tests to ensure symmetric behavior on (+) and (.) operators.

This time, we don't change any of the set tests.

All of the 'showkv' calls were removed as they are no longer necessary
and several new tests to ensure symmetric behavior on (+) and (.) operators.
@zoffixznet
Copy link
Contributor

zoffixznet commented Jan 1, 2017

How come showkv are no longer needed? Setties/Baggies are unordered so how they stringify is not predicable, or is it?

I know if the tests are changed to is-deeply instead of is then we won't need showkv for sure....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants